NFC: ExtractIRForPassTest.py: add tool path option and -hlsl-passes-pause#8447
Open
tex3d wants to merge 2 commits into
Open
NFC: ExtractIRForPassTest.py: add tool path option and -hlsl-passes-pause#8447tex3d wants to merge 2 commits into
tex3d wants to merge 2 commits into
Conversation
…ause Adds a -t or --tool-path option for specifying the directory containing dxc and dxopt tools and improves error handling for missing tools. Also adds -hlsl-passes-pause to the suggested test RUN line after the target pass, since this is needed to update the metadata in the resulting checked IR, when a pass might impact HLModule or DxilModule state.
bob80905
approved these changes
May 12, 2026
| dxopt_path = os.path.join(args.tool_path, dxopt_path) | ||
| if not os.path.isfile(dxc_path) or not os.path.isfile(dxopt_path): | ||
| raise FileNotFoundError( | ||
| f"dxc not found at {dxc_path}. Use -t to specify path to dxc and dxopt." |
Collaborator
There was a problem hiding this comment.
An error may be raised if dxopt isn't found, couldn't this be clarified with the below error message that you wrote?
Contributor
Author
There was a problem hiding this comment.
The difference is that this one was an explicit tools path, while the other one is the default which searches the PATH for dxc. But now that I look at it, I realize this needs a slight adjustment: it should say dxc or dxopt not found in specified tool path: {args.tool_path}..
Contributor
Author
There was a problem hiding this comment.
I fixed that, plus added tools path directory check first.
bob80905
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a -t or --tool-path option for specifying the directory containing dxc and dxopt tools and improves error handling for missing tools.
Also adds -hlsl-passes-pause to the suggested test RUN line after the target pass, since this is needed to update the metadata in the resulting checked IR, when a pass might impact HLModule or DxilModule state.